linux-kernel - Re: [tip:locking/core] locking/refcount: Create unchecked atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170904193643.GC17526@worktop.programming.kicks-ass.net>
Date:   Mon, 4 Sep 2017 21:36:43 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     davem@...emloft.net, arnd@...db.de, manfred@...orfullife.com,
        riel@...hat.com, hpa@...or.com, ebiggers3@...il.com,
        elena.reshetova@...el.com, keescook@...omium.org,
        dwindsor@...il.com, mingo@...nel.org, jannh@...gle.com,
        serge@...lyn.com, gregkh@...uxfoundation.org,
        ebiederm@...ssion.com, ishkamiel@...il.com, tglx@...utronix.de,
        hch@...radead.org, jpoimboe@...hat.com,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, dave@...olabs.net,
        linux-arch@...r.kernel.org, James.Bottomley@...senpartnership.com,
        linux-tip-commits@...r.kernel.org
Subject: Re: [tip:locking/core] locking/refcount: Create unchecked atomic_t
 implementation

On Mon, Sep 04, 2017 at 08:34:44PM +0300, Alexey Dobriyan wrote:
> On Mon, Sep 04, 2017 at 02:37:24PM +0200, Peter Zijlstra wrote:
> > -	 once.o refcount.o usercopy.o errseq.o
> > -obj-y += string_helpers.o
> > +	 once.o usercopy.o errseq.o string_helpers.o hexdump.o kstrtox.o
> > +
> > +obj-$(CONFIG_REFCOUNT_FULL) += refcount.o
> >  obj-$(CONFIG_TEST_STRING_HELPERS) += test-string_helpers.o
> > -obj-y += hexdump.o
> >  obj-$(CONFIG_TEST_HEXDUMP) += test_hexdump.o
> > -obj-y += kstrtox.o
> 
> File per line so everything is not lumped together even if it is obj-y.

If that is policy mass convert everything and be done with it. Otherwise
I'll continue to use the predominant pattern, which in this case is a
giant obj-y +=. But mixed stuff is terribly annoying.