linux-kernel - Re: linux-next: manual merge of the tip tree with the net-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170905100546.4b20136f@canb.auug.org.au>
Date:   Tue, 5 Sep 2017 10:05:46 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     David Miller <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Intiyaz Basha <intiyaz.basha@...ium.com>,
        Ying Huang <ying.huang@...el.com>
Subject: Re: linux-next: manual merge of the tip tree with the net-next tree

Hi Dave,

On Thu, 31 Aug 2017 13:47:02 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Today's linux-next merge of the tip tree got a conflict in:
> 
>   drivers/net/ethernet/cavium/liquidio/lio_main.c
> 
> between commit:
> 
>   d1d97ee6e3a8 ("liquidio: moved liquidio_napi_drv_callback to lio_core.c")
> 
> from the net-next tree and commit:
> 
>   966a967116e6 ("smp: Avoid using two cache lines for struct call_single_data")
> 
> from the tip tree.
> 
> I fixed it up (I added the blow merge fix patch) and can carry the fix
> as necessary. This is now fixed as far as linux-next is concerned, but
> any non trivial conflicts should be mentioned to your upstream maintainer
> when your tree is submitted for merging.  You may also want to consider
> cooperating with the maintainer of the conflicting tree to minimise any
> particularly complex conflicts.
> 
> From: Stephen Rothwell <sfr@...b.auug.org.au>
> Date: Thu, 31 Aug 2017 13:42:50 +1000
> Subject: [PATCH] liquidio: fix for merge with "smp: Avoid using two cache
>  lines for struct call_single_data"
> 
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
> ---
>  drivers/net/ethernet/cavium/liquidio/lio_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c
> index 0e7896cdb295..23f6b60030c5 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c
> @@ -613,7 +613,7 @@ static void liquidio_napi_drv_callback(void *arg)
>  	    droq->cpu_id == this_cpu) {
>  		napi_schedule_irqoff(&droq->napi);
>  	} else {
> -		struct call_single_data *csd = &droq->csd;
> +		call_single_data_t *csd = &droq->csd;
>  
>  		csd->func = napi_schedule_wrapper;
>  		csd->info = &droq->napi;

The above merge fix patch is now needed when I merge the net-next tree
with Linus' tree (since the tip commit has been merged by Linus).

-- 
Cheers,
Stephen Rothwell