linux-kernel - Re: [PATCH] ASoC: improve RT5514 dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a1PgN=XmAuKrFGT50f4otXzRsPqjYM3bjjKU3DgY7wWLg@mail.gmail.com>
Date:   Tue, 5 Sep 2017 11:03:04 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Mark Brown <broonie@...nel.org>
Cc:     Takashi Iwai <tiwai@...e.de>, Liam Girdwood <lgirdwood@...il.com>,
        alsa-devel@...a-project.org,
        Matthias Brugger <matthias.bgg@...il.com>,
        Hsin-yu Chao <hychao@...gle.com>,
        Harsha Priya N <harshapriya.n@...el.com>,
        Naveen M <naveen.m@...el.com>,
        Vinod Koul <vinod.koul@...el.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC..." 
        <linux-mediatek@...ts.infradead.org>,
        "open list:ARM/Rockchip SoC support" 
        <linux-rockchip@...ts.infradead.org>,
        Ryder Lee <ryder.lee@...iatek.com>,
        Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Sugar Zhang <sugar.zhang@...k-chips.com>,
        Xing Zheng <zhengxing@...k-chips.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: improve RT5514 dependencies

On Tue, Aug 1, 2017 at 4:21 PM, Mark Brown <broonie@...nel.org> wrote:
> On Mon, Jul 31, 2017 at 11:15:57AM +0200, Takashi Iwai wrote:
>
>> IMO, flipping the dependency looks saner to me.  The SPI function call
>> is a kind of add-on, after all.
>
> Yes, that's definitely the intention of the code.

I just ran into the same problem again on randconfig testing, after
the bug had been
gone before my vacation:

    sound/soc/codecs/rt5514.o: In function `rt5514_dsp_voice_wake_up_put':
    rt5514.c:(.text+0x2068): undefined reference to `rt5514_spi_burst_write'
    rt5514.c:(.text+0x20c8): undefined reference to `rt5514_spi_burst_write'

Is anyone looking into this? My original patch
(https://patchwork.kernel.org/patch/9871255/) still fixes it but needs a
minor change to apply now. When I last looked into changing
the dependency in the code, I couldn't quite figure out how to
do it there.

         Arnd