linux-kernel - Re: [PATCH] tracing: Fix clear of RECORDED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170905115951.2765f912@gandalf.local.home>
Date:   Tue, 5 Sep 2017 11:59:51 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Chunyu Hu <chuhu@...hat.com>
Cc:     mingo@...nel.org, linux-kernel@...r.kernel.org,
        Joel Fernandes <joelaf@...gle.com>
Subject: Re: [PATCH] tracing: Fix clear of RECORDED_TGID flag when disabling
 trace event

On Tue,  5 Sep 2017 13:36:46 +0800
Chunyu Hu <chuhu@...hat.com> wrote:

> When disabling one trace event, the RECORDED_TGID flag in the event
> file is not correctly cleared. It's clearing RECORDED_CMD flag when
> it should clear RECORDED_TGID flag. Fix d914ba37("tracing: Add support
> for recording tgid of tasks")
> 
> Signed-off-by: Chunyu Hu <chuhu@...hat.com>

Thanks! Applied.

-- Steve

> ---
>  kernel/trace/trace_events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index c93540c..8746839 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -406,7 +406,7 @@ static int __ftrace_event_enable_disable(struct trace_event_file *file,
>  
>  			if (file->flags & EVENT_FILE_FL_RECORDED_TGID) {
>  				tracing_stop_tgid_record();
> -				clear_bit(EVENT_FILE_FL_RECORDED_CMD_BIT, &file->flags);
> +				clear_bit(EVENT_FILE_FL_RECORDED_TGID_BIT, &file->flags);
>  			}
>  
>  			call->class->reg(call, TRACE_REG_UNREGISTER, file);