linux-kernel - Re: [PATCH v3 2/5] dt-bindings: input: Add document bindings for mtk-pmic-keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLe3o+iw0Wh=g5Ks93qM1BR1+S04Nv1R3FV17Z3dph1jg@mail.gmail.com>
Date:   Tue, 5 Sep 2017 11:05:27 -0500
From:   Rob Herring <robh@...nel.org>
To:     Chen Zhong <chen.zhong@...iatek.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Eddie Huang <eddie.huang@...iatek.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        Andi Shyti <andi.shyti@...sung.com>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Jaechul Lee <jcsing.lee@...sung.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-mediatek@...ts.infradead.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-rtc@...r.kernel.org
Subject: Re: [PATCH v3 2/5] dt-bindings: input: Add document bindings for mtk-pmic-keys

On Fri, Sep 1, 2017 at 9:16 PM, Chen Zhong <chen.zhong@...iatek.com> wrote:
> On Thu, 2017-08-31 at 14:52 -0500, Rob Herring wrote:
>> On Fri, Aug 25, 2017 at 02:32:30PM +0800, Chen Zhong wrote:
>> > This patch adds the device tree binding documentation for the MediaTek
>> > pmic keys found on PMIC MT6397/MT6323.
>> >
>> > Signed-off-by: Chen Zhong <chen.zhong@...iatek.com>
>> > ---
>> >  .../devicetree/bindings/input/mtk-pmic-keys.txt    |   38 ++++++++++++++++++++
>> >  1 file changed, 38 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt
>> >
>> > diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt
>> > new file mode 100644
>> > index 0000000..100ec44
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt
>> > @@ -0,0 +1,38 @@
>> > +MediaTek MT6397/MT6323 PMIC Keys Device Driver
>> > +
>> > +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey
>> > +and homekey. The key functions are defined as the subnode of the function
>> > +node provided by MT6397/MT6323 PMIC that is being defined as one kind
>> > +of Muti-Function Device (MFD)
>> > +
>> > +For MT6397/MT6323 MFD bindings see:
>> > +Documentation/devicetree/bindings/mfd/mt6397.txt
>> > +
>> > +Required properties:
>> > +- compatible: "mediatek,mt6397-keys" or "mediatek,mt6323-keys"
>> > +- linux,keycodes: Specifies the numeric keycode values to
>> > +   be used for reporting keys presses. The array can
>> > +   contain up to 2 entries.
>> > +
>> > +Optional Properties:
>> > +- wakeup-source: each key can be used as a wakeup source.
>>
>> wakeup-source is defined as a boolean.
>
> Hi Rob,
>
> Could I modify it as this?
>
> mediatek,wakeup-keys = <1>, <0>;
> wakeup-source;

What do the values and index signify? The power key is index 0 and the
value 1 means enable wakeup? Or each value is the raw key (i.e.
indexes in linux,keycode) that wakeup is enabled for?

I don't think this should be in DT really. It's really up to the user
(i.e. userspace) to decide what keys cause wakeup (or maybe that's
only suspend). If you default to the power key causes wakeup, do you
really need to support different options?

If we do put this in DT, then it should be a common binding to specify
keys that cause wake-up.

Rob