linux-kernel - Re: [PATCH 10/13] sgi-gru: update to new mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170905162112.GC14176@hpe.com>
Date:   Tue, 5 Sep 2017 11:21:12 -0500
From:   Dimitri Sivanich <sivanich@....com>
To:     jglisse@...hat.com
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Dimitri Sivanich <sivanich@....com>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrea Arcangeli <aarcange@...hat.com>
Subject: Re: [PATCH 10/13] sgi-gru: update to new mmu_notifier semantic

Acked-by: Dimitri Sivanich <sivanich@....com>

On Thu, Aug 31, 2017 at 05:17:35PM -0400, jglisse@...hat.com wrote:
> From: Jérôme Glisse <jglisse@...hat.com>
> 
> Call to mmu_notifier_invalidate_page() are replaced by call to
> mmu_notifier_invalidate_range() and thus call are bracketed by
> call to mmu_notifier_invalidate_range_start()/end()
> 
> Remove now useless invalidate_page callback.
> 
> Signed-off-by: Jérôme Glisse <jglisse@...hat.com>
> Cc: Dimitri Sivanich <sivanich@....com>
> Cc: Jack Steiner <steiner@....com>
> Cc: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Andrea Arcangeli <aarcange@...hat.com>
> ---
>  drivers/misc/sgi-gru/grutlbpurge.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/misc/sgi-gru/grutlbpurge.c b/drivers/misc/sgi-gru/grutlbpurge.c
> index e936d43895d2..9918eda0e05f 100644
> --- a/drivers/misc/sgi-gru/grutlbpurge.c
> +++ b/drivers/misc/sgi-gru/grutlbpurge.c
> @@ -247,17 +247,6 @@ static void gru_invalidate_range_end(struct mmu_notifier *mn,
>  	gru_dbg(grudev, "gms %p, start 0x%lx, end 0x%lx\n", gms, start, end);
>  }
>  
> -static void gru_invalidate_page(struct mmu_notifier *mn, struct mm_struct *mm,
> -				unsigned long address)
> -{
> -	struct gru_mm_struct *gms = container_of(mn, struct gru_mm_struct,
> -						 ms_notifier);
> -
> -	STAT(mmu_invalidate_page);
> -	gru_flush_tlb_range(gms, address, PAGE_SIZE);
> -	gru_dbg(grudev, "gms %p, address 0x%lx\n", gms, address);
> -}
> -
>  static void gru_release(struct mmu_notifier *mn, struct mm_struct *mm)
>  {
>  	struct gru_mm_struct *gms = container_of(mn, struct gru_mm_struct,
> @@ -269,7 +258,6 @@ static void gru_release(struct mmu_notifier *mn, struct mm_struct *mm)
>  
>  
>  static const struct mmu_notifier_ops gru_mmuops = {
> -	.invalidate_page	= gru_invalidate_page,
>  	.invalidate_range_start	= gru_invalidate_range_start,
>  	.invalidate_range_end	= gru_invalidate_range_end,
>  	.release		= gru_release,
> -- 
> 2.13.5
>