linux-kernel - [PATCH] binder: fix an ret value override

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20170905172538.36758-1-tkjos@google.com>
Date:   Tue,  5 Sep 2017 10:25:38 -0700
From:   Todd Kjos <tkjos@...roid.com>
To:     gregkh@...uxfoundation.org, arve@...roid.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        maco@...gle.com, tkjos@...gle.com, xuyiping@...ilicon.com,
        gengyanping@...ilicon.com, shiwanglai@...ilicon.com
Cc:     Xu YiPing <xuyiping@...licon.com>
Subject: [PATCH] binder: fix an ret value override

From: Xu YiPing <xuyiping@...ilicon.com>

commit 372e3147df70 ("binder: guarantee txn complete / errors delivered
in-order") incorrectly defined a local ret value.  This ret value will
be invalid when out of the if block

Signed-off-by: Xu YiPing <xuyiping@...licon.com>
Signed-off-by: Todd Kjos <tkjos@...gle.com>
---
 drivers/android/binder.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 96cc28afa383..7ef9e7f05e17 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2326,7 +2326,6 @@ static int binder_translate_handle(struct flat_binder_object *fp,
 			     (u64)node->ptr);
 		binder_node_unlock(node);
 	} else {
-		int ret;
 		struct binder_ref_data dest_rdata;
 
 		binder_node_unlock(node);
-- 
2.14.1.581.gf28d330327-goog