linux-kernel - Re: [PATCH] media: leds: as3645a: add V4L2_FLASH_LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Sep 2017 23:18:07 +0300
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Mauro Carvalho Chehab <mchehab@...pensource.com>,
        Richard Purdie <rpurdie@...ys.net>, Pavel Machek <pavel@....cz>
Cc:     linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linux Media Mailing List <linux-media@...r.kernel.org>
Subject: Re: [PATCH] media: leds: as3645a: add V4L2_FLASH_LED_CLASS
 depdendency

Hi Jacek and Arnd,

Thanks for fixing this plus the ack! I chatted with Mauro, and as the 
patches are still only in mediatree, we'll apply this there, possibly 
with a minor spelling fix to the subject (depdendency -> dependency).

<URL:https://git.linuxtv.org/sailus/media_tree.git/commit/?h=as3645a-fix2>

Cc linux-media.

Jacek Anaszewski wrote:
> Hi Arnd,
>
> Thanks for the patch.
>
> On 09/05/2017 09:13 AM, Arnd Bergmann wrote:
>> We get a link error when V4L2_FLASH_LED_CLASS=m and AS3645A is built-in:
>>
>> drivers/leds/leds-as3645a.o: In function `as3645a_v4l2_setup':
>> leds-as3645a.c:(.text+0x258): undefined reference to `v4l2_flash_init'
>> leds-as3645a.c:(.text+0x284): undefined reference to `v4l2_flash_indicator_init'
>> leds-as3645a.c:(.text+0x2a4): undefined reference to `v4l2_flash_release'
>> drivers/leds/leds-as3645a.o: In function `as3645a_remove':
>> leds-as3645a.c:(.text+0x784): undefined reference to `v4l2_flash_release'
>>
>> This adds the same Kconfig dependency that the other V4L2 flash
>> drivers in drivers/leds use, to avoid that broken configuration.
>>
>> Fixes: a56ba8fbcb55 ("media: leds: as3645a: Add LED flash class driver")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>>  drivers/leds/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> The patch that caused the problem is currently in the v4l git tree,
>> rather than the leds tree. Please merge this through an appropriate
>> path, either v4l or led, depending on the timing.
>>
>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>> index 0bf022bcb6ac..52ea34e337cd 100644
>> --- a/drivers/leds/Kconfig
>> +++ b/drivers/leds/Kconfig
>> @@ -61,6 +61,7 @@ config LEDS_AAT1290
>>  config LEDS_AS3645A
>>  	tristate "AS3645A LED flash controller support"
>>  	depends on I2C && LEDS_CLASS_FLASH
>> +	depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
>>  	help
>>  	  Enable LED flash class support for AS3645A LED flash
>>  	  controller. V4L2 flash API is provided as well if
>>
>
> Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
>


-- 
Sakari Ailus
sakari.ailus@...ux.intel.com