linux-kernel - Re: [PATCH v2] clk: at91: utmi: set the mainck rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170905061134.f6n6jtvz57ycqd2f@rfolt0960.corp.atmel.com>
Date:   Tue, 5 Sep 2017 08:11:34 +0200
From:   Ludovic Desroches <ludovic.desroches@...rochip.com>
To:     Ingo van Lil <inguin@....de>
CC:     Ludovic Desroches <ludovic.desroches@...rochip.com>,
        <linux-clk@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <boris.brezillon@...e-electrons.com>, <mturquette@...libre.com>,
        <sboyd@...eaurora.org>, <nicolas.ferre@...rochip.com>,
        <alexandre.belloni@...e-electrons.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] clk: at91: utmi: set the mainck rate

On Mon, Sep 04, 2017 at 07:53:57PM +0200, Ingo van Lil wrote:
> On 09/04/2017 11:52 AM, Ludovic Desroches wrote:
> 
> > +	/* SFR node missing is not necessarily an issue. */
> > +	regmap_sfr = syscon_regmap_lookup_by_compatible("atmel,sama5d2-sfr");
> > +	if (IS_ERR(regmap_sfr))
> > +		regmap_sfr = NULL;
> 
> What about SAMA5D3? That chip has an UTMICKTRIM register, too (SAMA5D4
> doesn't, though).

Oh Yes. I'll look for atmel,sama5d3-sfr too. Maybe there is a smarter
solution but I don't have it in mind.

> 
> Otherwise the patch looks good and works fine on both my boards (SAMA5D2
> 16MHz and SAMA5D3 12MHz).

Thanks for testing.

Regards

Ludovic