linux-kernel - Re: [PATCH v2] drivers/mailbox: Add Aspeed mailbox driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170905062510.GA16418@kroah.com>
Date:   Tue, 5 Sep 2017 08:25:10 +0200
From:   Greg KH <greg@...ah.com>
To:     Cyril Bur <cyrilbur@...il.com>
Cc:     Jassi Brar <jassisinghbrar@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        openbmc@...ts.ozlabs.org, Joel Stanley <joel.stan@...il.com>
Subject: Re: [PATCH v2] drivers/mailbox: Add Aspeed mailbox driver

On Tue, Sep 05, 2017 at 09:37:19AM +1000, Cyril Bur wrote:
> On Mon, 2017-09-04 at 20:13 +0530, Jassi Brar wrote:
> > On Mon, Sep 4, 2017 at 12:47 PM, Cyril Bur <cyrilbur@...il.com> wrote:
> > > Hi,
> > > 
> > > I haven't heard anything about this driver. I'm trying to interpret if
> > > the silence is because there is something fundamentally wrong with the
> > > driver or is it because it doesn't use any of the mailbox
> > > infrastructure it is being ignored.
> > > 
> > 
> > Its the latter.
> 
> Great! Thanks for your response, I'll resend it under char/misc.

Wait, no, please use the mailbox infrastructure for this, making a
one-off char/misc driver isn't ok when there is a framework for you to
use.

thanks,

greg k-h