linux-kernel - Re: [PATCH] HID: hid-lg: make array cbuf static const to shink object code size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1709061058560.4077@jbgna.fhfr.qr>
Date:   Wed, 6 Sep 2017 10:59:04 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Colin King <colin.king@...onical.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: hid-lg: make array cbuf static const to shink object
 code size

On Fri, 25 Aug 2017, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate array cbuf on the stack, instead make it static.
> Makes the object code smaller by over 110 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   15096	   3504	    128	  18728	   4928	drivers/hid/hid-lg.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   14884	   3600	    128	  18612	   48b4	drivers/hid/hid-lg.o
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs