[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d6d32dcf-49fe-b209-d7ed-64624821b320@huawei.com>
Date: Wed, 6 Sep 2017 17:09:16 +0800
From: "chengjian (D)" <cj.chengjian@...wei.com>
To: Thomas Gleixner <tglx@...utronix.de>
CC: <huawei.libin@...wei.com>, <mingo@...hat.com>,
<peterz@...radead.org>, <dvhart@...radead.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: a competition when some threads acquire futex
On 2017/9/6 16:36, Thomas Gleixner write:
> Ok. Still that patch has issues.
>
> 1) It's white space damaged. Please use TAB not spaces for
> indentation. checkpatch.pl would have told you.
>
> 2) Why are you using _cond_resched() instead of plain cond_resched().
>
> cond_resched() is what you want to use.
Hi Thomas.
I am very sorry about the issues of my patch.
I am a kernel newbie and i set expandtab in my .vimrc file
which means tab characters are converted to spaces.
I have fixed it and will check my patch first next time.
Thanks.
Cheng Jian
Powered by blists - more mailing lists