linux-kernel - Re: [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0ffc120-c655-70ec-3b79-5bccbd98f169@ti.com>
Date:   Wed, 6 Sep 2017 16:26:34 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Keerthy <j-keerthy@...com>, <bhelgaas@...gle.com>
CC:     <t-kristo@...com>, <linux-kernel@...r.kernel.org>,
        <linux-omap@...r.kernel.org>, <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn
 off clocks



On Wednesday 06 September 2017 04:23 PM, Kishon Vijay Abraham I wrote:
> Keerthy,
> 
> On Wednesday 06 September 2017 04:09 PM, Keerthy wrote:
>> Add shutdown handler to cleanly turn off clocks.
> 
> one minor comment below.. with that fixed you can add my
> 
> Acked-by: Kishon Vijay Abraham I <kishon@...com>
>>
>> Signed-off-by: Keerthy <j-keerthy@...com>
>> ---
>>  drivers/pci/dwc/pci-dra7xx.c | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>> index d4e98f3..66d1cfe 100644
>> --- a/drivers/pci/dwc/pci-dra7xx.c
>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>> @@ -874,6 +874,19 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
>>  	return 0;
>>  }
>>  
>> +void dra7xx_pcie_shutdown(struct platform_device *pdev)
>> +{
>> +	struct dra7xx_pcie *dra7xx = dev_get_drvdata(&pdev->dev);
> 
> Use struct device *dev = &pdev->dev, instead of de-referencing device pointer
> multiple times.

You might also have to dra7xx_pcie_stop_link() before disabling the clocks.

Thanks
Kishon