linux-kernel - Re: [PATCH] tty: xilinx_uartps: move to arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72a8ba54-69fb-5a69-35b3-8c9e277621fb@xilinx.com>
Date:   Wed, 6 Sep 2017 14:43:40 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Michal Simek <michal.simek@...inx.com>
CC:     Greg KH <gregkh@...uxfoundation.org>,
        Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        <shubhrajyoti.datta@...il.com>
Subject: Re: [PATCH] tty: xilinx_uartps: move to arch_initcall for earlier
 console

On 31.8.2017 14:59, Linus Walleij wrote:
> On Thu, Aug 24, 2017 at 11:32 AM, Michal Simek <michal.simek@...inx.com> wrote:
>> On 24.8.2017 01:24, Greg KH wrote:
>>> On Wed, Aug 23, 2017 at 04:50:21PM +0530, Shubhrajyoti Datta wrote:
>>>> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
>>>
>>> I can't take patches without any changelog text at all :(
>>
>> ok. I see you have also commented this.
>>
>> Anyway this is kind of old discussion about moving serial drivers to
>> arch_initcall from module_init.
>>
>> There is one patch in the tree.
>>
>> commit 4dd9e742df98f8f600b4302d3adbb087a68237f7
>> Author:     Alessandro Rubini <rubini@...dd.com>
>> AuthorDate: Tue May 5 05:54:13 2009 +0100
>> Commit:     Russell King <rmk+kernel@....linux.org.uk>
>> CommitDate: Sun May 31 14:58:11 2009 +0100
>>
>>     [ARM] 5505/1: serial amba-pl011: move to arch_initcall for earlier
>> console
>>
>>     Signed-off-by: Alessandro Rubini <rubini@...pv.it>"
>>     Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
>>
>>
>> and then there was one patch (also sent to linux-serial but don't have link)
>> https://patches.linaro.org/patch/14633/
>>
>> where that discussion wasn't finished.
> 
> Yeah Alessandro never came back on that.
> 
> I *guess* it is to get the console up really early, simply becaus it is
> quite helpful for spotting early boot problems.


ok. It means no concern about the move to arch_initcall.
Shubhrajyoti: Please send v2 with changelog.

Thanks,
Michal