linux-kernel - Re: n900 in next-20170901

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170906133057.GH5024@atomide.com>
Date:   Wed, 6 Sep 2017 06:30:57 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Joonsoo Kim <iamjoonsoo.kim@....com>
Cc:     Pavel Machek <pavel@....cz>, pali.rohar@...il.com, sre@...nel.org,
        kernel list <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-omap@...r.kernel.org, khilman@...nel.org,
        aaro.koskinen@....fi, ivo.g.dimitrov.75@...il.com,
        patrikbachan@...il.com, serge@...lyn.com, abcloriens@...il.com,
        "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Russell King <linux@...linux.org.uk>
Subject: Re: n900 in next-20170901

Hi,

* Joonsoo Kim <iamjoonsoo.kim@....com> [170905 16:32]:
> I think that I made a mistake for configuration CONFIG_HIGHMEM=y and
> CONFIG_HAVE_MEMBLOCK_NODE_MAP=y. In this case, the MOVABLE_ZONE can
> be *!highmem*. Could you check that your configuration have above
> options?

CONFIG_HIGHMEM is set yeah.

> And, could you check that following patch works for you?

Does not seem to help, tried against next with just 9caf25f996e8
revert and also with 9caf25f996e8.

Regards,

Tony


> ------------>8-----------------
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index 38f0fde..4c39c92 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -518,7 +518,7 @@ void __init dma_contiguous_remap(void)
>                  * considered as highmem even if it's physical address belong
>                  * to lowmem. Therefore, re-mapping isn't required.
>                  */
> -               if (!IS_ENABLED(CONFIG_HIGHMEM))
> +               if (!is_highmem_idx(ZONE_MOVABLE))
>                         iotable_init(&map, 1);
>         }
>  }
>