linux-kernel - Re: [PATCH] MIPS: ath79: support devicetree selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170906153543.412774d5@avionic-0141>
Date:   Wed, 6 Sep 2017 15:35:43 +0200
From:   Alban <albeu@...e.fr>
To:     Rocco Folino <rocco.folino@...il.com>
Cc:     Alban <albeu@...e.fr>, Ralf Baechle <ralf@...ux-mips.org>,
        robh+dt@...nel.org, mark.rutland@....com,
        linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org,
        Antony Pavlov <antonynpavlov@...il.com>,
        John Crispin <john@...ozen.org>
Subject: Re: [PATCH] MIPS: ath79: support devicetree selection

On Wed, 6 Sep 2017 14:32:00 +0200
Rocco Folino <rocco.folino@...il.com> wrote:

> On Wed, Sep 06, 2017 at 02:20:05PM +0200, Alban wrote:
> > On Wed, 6 Sep 2017 13:14:35 +0200
> > Ralf Baechle <ralf@...ux-mips.org> wrote:
> >   
> > > On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> > >   
> > > > Allow to choose devicetrees from Kconfig.
> > > > 
> > > > Signed-off-by: Rocco Folino <rocco.folino@...il.com>  
> > 
> > I don't really see the point of this patch. Building the dtb doesn't
> > take any significant time, so why add this extra complexity?  
> 
> Because you need to select the SoC type in order to enable some
> drivers, for example on the AR9331 to use the serial you need the
> CONFIG_SERIAL_AR933X which depends on the CONFIG_SOC_AR933X.

Seeing as this driver is the only one that make use of CONFIG_SOC_AR933X
I would prefer removing this dependency. It would also open the way to have
the driver built in COMPILE_TEST. A few more fixes might be needed but that
would be better than such a workaround.

Alban

Content of type "application/pgp-signature" skipped