linux-kernel - Re: [PATCH 01/18] lightnvm: pblk: improve naming for internal req.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Sep 2017 16:01:43 +0200
From:   Javier González <jg@...htnvm.io>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Matias Bjørling <mb@...htnvm.io>,
        Jens Axboe <axboe@...com>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Matias Bjørling <matias@...xlabs.com>
Subject: Re: [PATCH 01/18] lightnvm: pblk: improve naming for internal req.

> On 6 Sep 2017, at 15.46, Christoph Hellwig <hch@...radead.org> wrote:
> 
>> -#define ERASE 2 /* READ = 0, WRITE = 1 */
>> +/* READ = 0, WRITE (user) = 1 */
>> +#define ERASE 2
>> +#define WRITE_INT 3 /* Internal write. Not through write buffer */
> 
> enum {
> 	PBLK_READ,
> 	PBLK_WRITE,
> 	PBLK_ERASE,
> 	PBLK_WRITE,
> };
> 
> please.  Don't abuse and overload the messy READ/WRITE macros in any
> new code.

Ok. I'll resend.

Javier

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)