linux-kernel - RE: [PATCH 06/13] IB/hfi1: update to new mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A503C24F5B2FB844864C0DD400A8F742BE12B1@ORSMSX113.amr.corp.intel.com>
Date:   Wed, 6 Sep 2017 14:08:04 +0000
From:   "Arumugam, Kamenee" <kamenee.arumugam@...el.com>
To:     Jérôme Glisse <jglisse@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>
CC:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "Luick, Dean" <dean.luick@...el.com>,
        "Weiny, Ira" <ira.weiny@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrea Arcangeli <aarcange@...hat.com>
Subject: RE: [PATCH 06/13] IB/hfi1: update to new mmu_notifier semantic

Tested this patch with hfi1 driver and no issue found. 

Tested-by: Kamenee Arumugam <kamenee.arumugam@...el.com>

-----Original Message-----
From: linux-rdma-owner@...r.kernel.org [mailto:linux-rdma-owner@...r.kernel.org] On Behalf Of Jérôme Glisse
Sent: Tuesday, August 29, 2017 7:55 PM
To: linux-kernel@...r.kernel.org; linux-mm@...ck.org
Cc: Jérôme Glisse <jglisse@...hat.com>; linux-rdma@...r.kernel.org; Luick, Dean <dean.luick@...el.com>; Weiny, Ira <ira.weiny@...el.com>; Doug Ledford <dledford@...hat.com>; Kirill A . Shutemov <kirill.shutemov@...ux.intel.com>; Andrew Morton <akpm@...ux-foundation.org>; Linus Torvalds <torvalds@...ux-foundation.org>; Andrea Arcangeli <aarcange@...hat.com>
Subject: [PATCH 06/13] IB/hfi1: update to new mmu_notifier semantic

Call to mmu_notifier_invalidate_page() are replaced by call to
mmu_notifier_invalidate_range() and thus call are bracketed by call to mmu_notifier_invalidate_range_start()/end()

Remove now useless invalidate_page callback.

Signed-off-by: Jérôme Glisse <jglisse@...hat.com>
Cc: linux-rdma@...r.kernel.org
Cc: Dean Luick <dean.luick@...el.com>
Cc: Ira Weiny <ira.weiny@...el.com>
Cc: Doug Ledford <dledford@...hat.com>
Cc: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Andrea Arcangeli <aarcange@...hat.com>
---
 drivers/infiniband/hw/hfi1/mmu_rb.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/infiniband/hw/hfi1/mmu_rb.c b/drivers/infiniband/hw/hfi1/mmu_rb.c
index ccbf52c8ff6f..e4b56a0dd6d0 100644
--- a/drivers/infiniband/hw/hfi1/mmu_rb.c
+++ b/drivers/infiniband/hw/hfi1/mmu_rb.c
@@ -67,8 +67,6 @@ struct mmu_rb_handler {
 
 static unsigned long mmu_node_start(struct mmu_rb_node *);  static unsigned long mmu_node_last(struct mmu_rb_node *); -static inline void mmu_notifier_page(struct mmu_notifier *, struct mm_struct *,
-				     unsigned long);
 static inline void mmu_notifier_range_start(struct mmu_notifier *,
 					    struct mm_struct *,
 					    unsigned long, unsigned long); @@ -82,7 +80,6 @@ static void do_remove(struct mmu_rb_handler *handler,  static void handle_remove(struct work_struct *work);
 
 static const struct mmu_notifier_ops mn_opts = {
-	.invalidate_page = mmu_notifier_page,
 	.invalidate_range_start = mmu_notifier_range_start,  };
 
@@ -285,12 +282,6 @@ void hfi1_mmu_rb_remove(struct mmu_rb_handler *handler,
 	handler->ops->remove(handler->ops_arg, node);  }
 
-static inline void mmu_notifier_page(struct mmu_notifier *mn,
-				     struct mm_struct *mm, unsigned long addr)
-{
-	mmu_notifier_mem_invalidate(mn, mm, addr, addr + PAGE_SIZE);
-}
-
 static inline void mmu_notifier_range_start(struct mmu_notifier *mn,
 					    struct mm_struct *mm,
 					    unsigned long start,
--
2.13.5

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@...r.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html