linux-kernel - Re: [PATCH 1/1] drivers/tty: check for null pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 6 Sep 2017 16:18:55 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Li, Zhenhua" <lizhenhuajiyang@....com>
Cc:     "jslaby@...e.com" <jslaby@...e.com>,
        "mingo@...nel.org" <mingo@...nel.org>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "mail@...iej.szmigiero.name" <mail@...iej.szmigiero.name>,
        "mgorman@...e.de" <mgorman@...e.de>,
        "safinaskar@...l.ru" <safinaskar@...l.ru>,
        "mhocko@...e.com" <mhocko@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] drivers/tty: check for null pointer

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Wed, Sep 06, 2017 at 09:57:20PM +0800, Li, Zhenhua wrote:
> when I tried to boot linux on a system with virtual bios and vortual keyboard,
>  it crashes.

What exact "virtual bios and keyboard" are you referring to here?  QEMU?
Something else?

> The root cause is the bios does not initialize devices correctly.

How does the bios come into play here?  It should not matter, it should
only be a kernel driver that can set this value.

> did not track what drivers called this function.

What was the full oops message?  That should show the problem.

And by just rejecting the call here, you are probably just postponing
the real fix from happening, we should resolve that.

thanks,

greg k-h