linux-kernel - Re: [PATCH 1/1] workqueue: use type int instead of bool to index array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170906143320.GK1774378@devbig577.frc2.facebook.com>
Date:   Wed, 6 Sep 2017 07:33:20 -0700
From:   Tejun Heo <tj@...nel.org>
To:     zijun_hu <zijun_hu@...o.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, jiangshanlai@...il.com,
        linux-kernel@...r.kernel.org, zijun_hu@....com
Subject: Re: [PATCH 1/1] workqueue: use type int instead of bool to index
 array

Hello,

On Wed, Sep 06, 2017 at 11:34:14AM +0800, zijun_hu wrote:
> From: zijun_hu <zijun_hu@....com>
> 
> type bool is used to index three arrays in alloc_and_link_pwqs()
> it doesn't look like conventional.
> 
> it is fixed by using type int to index the relevant arrays.

bool is a uint type which can be either 0 or 1.  I don't see what the
benefit of this patch is.q

Thanks.

-- 
tejun