lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Sep 2017 17:12:59 +0200 From: Johannes Thumshirn <jthumshirn@...e.de> To: Jens Axboe <axboe@...nel.dk> Cc: Javier González <jg@...htnvm.io>, mb@...htnvm.io, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, Javier González <javier@...xlabs.com>, Matias Bjørling <matias@...xlabs.com> Subject: Re: [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc. On Wed, Sep 06, 2017 at 09:09:29AM -0600, Jens Axboe wrote: > On 09/06/2017 09:08 AM, Johannes Thumshirn wrote: > > On Wed, Sep 06, 2017 at 05:01:01PM +0200, Javier González wrote: > >> Check for failed mempool allocations and act accordingly. > > > > Are you sure it is needed? Quoting from mempool_alloc()s Documentation: > > "[...] Note that due to preallocation, this function *never* fails when called > > from process contexts. (it might fail if called from an IRQ context.) [...]" > > It's not needed, mempool() will never fail if __GFP_WAIT is set in the > mask. The use case here is GFP_KERNEL, which does include __GFP_WAIT. Exactly. Maybe I shouldn't have it phrased as a question though... -- Johannes Thumshirn Storage jthumshirn@...e.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Powered by blists - more mailing lists