linux-kernel - Re: [PATCH 1/1] workqueue: use type int instead of bool to index array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170906164015.GQ1774378@devbig577.frc2.facebook.com>
Date:   Wed, 6 Sep 2017 09:40:15 -0700
From:   Tejun Heo <tj@...nel.org>
To:     zijun_hu <zijun_hu@...o.com>
Cc:     zijun_hu@....com, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        jiangshanlai@...il.com
Subject: Re: [PATCH 1/1] workqueue: use type int instead of bool to index
 array

On Thu, Sep 07, 2017 at 12:04:59AM +0800, zijun_hu wrote:
> On 2017/9/6 22:33, Tejun Heo wrote:
> > Hello,
> > 
> > On Wed, Sep 06, 2017 at 11:34:14AM +0800, zijun_hu wrote:
> >> From: zijun_hu <zijun_hu@....com>
> >>
> >> type bool is used to index three arrays in alloc_and_link_pwqs()
> >> it doesn't look like conventional.
> >>
> >> it is fixed by using type int to index the relevant arrays.
> > 
> > bool is a uint type which can be either 0 or 1.  I don't see what the
> > benefit of this patch is.q
> > 
> bool is NOT a uint type now, it is a new type introduced by gcc, it is
> rather different with "typedef int bool" historically

http://www.open-std.org/jtc1/sc22/wg14/www/docs/n815.htm

  Because C has existed for so long without a Boolean type, however, the
  new standard must coexist with the old remedies. Therefore, the type
  name is taken from the reserved identifier space. To maintain
  orthogonal promotion rules, the Boolean type is defined as an unsigned
  integer type capable of representing the values 0 and 1. The more
  conventional names for the type and its values are then made available
  only with the inclusion of the <stdbool.h> header. In addition, the
  header defines a feature test macro to aid in integrating new code
  with old code that defines its own Boolean type.

-- 
tejun