linux-kernel - Re: [PATCH] [RESEND] IB/uverbs: fix gcc-7 type warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a2GjtSX2WLf93Rn8rhEG_UVoeCsRr9WLjQzR=Ykh88-gQ@mail.gmail.com>
Date:   Wed, 6 Sep 2017 22:43:47 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Doug Ledford <dledford@...hat.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        Matan Barak <matanb@...lanox.com>,
        Yishai Hadas <yishaih@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [RESEND] IB/uverbs: fix gcc-7 type warning

On Wed, Sep 6, 2017 at 3:58 PM, Christoph Hellwig <hch@...radead.org> wrote:
> On Wed, Sep 06, 2017 at 03:45:31PM +0200, Arnd Bergmann wrote:
>> We get a harmless warning about the fact that we use the result of a
>> multiplication as a condition:
>
> Please just turn the thing into a function while you're at it.
> I'm not even sure it needs to be inline..

Ok, the patch gets quite big once I also modify INIT_UDATA the same way,
but it seems like a good cleanup anyway. INIT_UDATA (renamed to
ib_uverbs_init_udata()) should definitely remain inline, so I'm leaving
both that way.

        Arnd