linux-kernel - Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Sep 2017 23:59:55 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Srishti Sharma <srishtishar@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        outreachy-kernel@...glegroups.com,
        driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

On Thu, Sep 07, 2017 at 12:54:23AM +0530, Srishti Sharma wrote:
> Correct spelling of counter in comment .
> 
> Signed-off-by: Srishti Sharma <srishtishar@...il.com>
> ---
>  drivers/staging/ccree/ssi_cipher.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
> index 8d31a93..99232b2 100644
> --- a/drivers/staging/ccree/ssi_cipher.c
> +++ b/drivers/staging/ccree/ssi_cipher.c
> @@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,
> 
>  	ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
> 
> -	/*Set the inflight couter value to local variable*/
> +	/*Set the inflight counter value to local variable*/
>  	inflight_counter =  ctx_p->drvdata->inflight_counter;

Sure, but it would be better to just delete the comment.  It's obvious.
But really just delete the local inflight_counter variable as well
because that's never used.

regards,
dan carpenter