linux-kernel - Re: [PATCH 1/1] x86:mm:return -ENOMEM if kzalloc() fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1504766795.7546.16.camel@perches.com>
Date:   Wed, 06 Sep 2017 23:46:35 -0700
From:   Joe Perches <joe@...ches.com>
To:     Allen <allen.lkml@...il.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH 1/1] x86:mm:return -ENOMEM if kzalloc() fails

On Thu, 2017-09-07 at 12:08 +0530, Allen wrote:
> > On Thu, 2017-09-07 at 11:56 +0530, Allen Pais wrote:
> > >  Currently on failure the value returned from kzalloc() is -1.
> > > It should return -ENOMEM.
> > > 
> > 
> > Looks like there are quite a few of these:
> > (probably several false positives too)
> 
>  The list is long. If the maintainers are okay with these clean-ups,
> i'll go ahead and get all of them done.

Make sure you check the calling chains to ensure that
the conversion from -1 to -12 doesn't break anything.