linux-kernel - Re: [PATCH] drivers/staging/pi433: Fixing coding guidelines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Sep 2017 11:32:13 +0200
From:   Greg KH <greg@...ah.com>
To:     Pushkar Jambhlekar <pushkar.iit@...il.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/staging/pi433: Fixing coding guidelines

On Wed, Sep 06, 2017 at 11:12:02AM +0530, Pushkar Jambhlekar wrote:
> Fix brace style of if-else case
> 
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@...il.com>
> ---
>  drivers/staging/pi433/pi433_if.c | 162 +++++++++++++--------------------------
>  1 file changed, 54 insertions(+), 108 deletions(-)
> 
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 93c0168..c070cf3 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -133,19 +133,16 @@ static irqreturn_t DIO0_irq_handler(int irq, void *dev_id)
>  {
>  	struct pi433_device *device = dev_id;
>  
> -	if      (device->irq_state[DIO0] == DIO_PacketSent)
> -	{
> +	if      (device->irq_state[DIO0] == DIO_PacketSent) {

Those extra spaces after "if" really don't need to be there either,
right?  Fix that at the same time please.

thanks,

greg k-h