linux-kernel - Re: [PATCH] drivers/staging/rtl8188eu: cleanup crc32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170907093348.GD8102@kroah.com>
Date:   Thu, 7 Sep 2017 11:33:48 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pushkar Jambhlekar <pushkar.iit@...il.com>
Cc:     Georgiana Rodica Chelu <georgiana.chelu93@...il.com>,
        William Blough <devel@...ugh.us>,
        Ivan Safonov <insafonov@...il.com>,
        Yamanappagouda Patil <goudapatilk@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/staging/rtl8188eu: cleanup crc32_init logic

On Thu, Sep 07, 2017 at 10:20:52AM +0530, Pushkar Jambhlekar wrote:
> crc32_init is using unnecessary else condition. Cleaningup this function
> 
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@...il.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_security.c | 42 +++++++++++++--------------
>  1 file changed, 21 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
> index b283a490..9d17204 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_security.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_security.c
> @@ -94,29 +94,29 @@ static u8 crc32_reverseBit(u8 data)
>  
>  static void crc32_init(void)
>  {
> -	if (bcrc32initialized == 1) {
> +	if (bcrc32initialized == 1)
>  		return;
> -	} else {
> -		int i, j;
> -		u32 c;
> -		u8 *p = (u8 *)&c, *p1;
> -		u8 k;
> -
> -		c = 0x12340000;
> -
> -		for (i = 0; i < 256; ++i) {
> -			k = crc32_reverseBit((u8)i);
> -			for (c = ((u32)k) << 24, j = 8; j > 0; --j)
> -				c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
> -			p1 = (u8 *)&crc32_table[i];
> -
> -			p1[0] = crc32_reverseBit(p[3]);
> -			p1[1] = crc32_reverseBit(p[2]);
> -			p1[2] = crc32_reverseBit(p[1]);
> -			p1[3] = crc32_reverseBit(p[0]);
> -		}
> -		bcrc32initialized = 1;
> +
> +	int i, j;
> +	u32 c;
> +	u8 *p = (u8 *)&c, *p1;
> +	u8 k;
> +
> +	c = 0x12340000;
> +
> +	for (i = 0; i < 256; ++i) {
> +		k = crc32_reverseBit((u8)i);
> +		for (c = ((u32)k) << 24, j = 8; j > 0; --j)
> +			c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
> +		p1 = (u8 *)&crc32_table[i];
> +
> +		p1[0] = crc32_reverseBit(p[3]);
> +		p1[1] = crc32_reverseBit(p[2]);
> +		p1[2] = crc32_reverseBit(p[1]);
> +		p1[3] = crc32_reverseBit(p[0]);
>  	}
> +
> +	bcrc32initialized = 1;
>  }
>  
>  static __le32 getcrc32(u8 *buf, int len)

Always test build your code and ensure that you did not add any new
build warnings or errors :(