linux-kernel - Re: [PATCH v5] Staging: ccree: Remove unused variable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB3L5oyx4Au-BhZCg7Eo2SBD5drFS0OS=NOM3qCtQ4hLumdg1A@mail.gmail.com>
Date:   Thu, 7 Sep 2017 15:26:42 +0530
From:   Srishti Sharma <srishtishar@...il.com>
To:     Gilad Ben-Yossef <gilad@...yossef.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        outreachy-kernel@...glegroups.com
Subject: Re: [PATCH v5] Staging: ccree: Remove unused variable.

On Thu, Sep 7, 2017 at 2:20 PM, Gilad Ben-Yossef <gilad@...yossef.com> wrote:
> Hi,
>
> On Thu, Sep 7, 2017 at 10:49 AM, Srishti Sharma <srishtishar@...il.com> wrote:
>> Remove the local variable inflight_counter as it is never used.
>>
>> Signed-off-by: Srishti Sharma <srishtishar@...il.com>
>> ---
>
> I've been meaning to clean that for some time now and never got around to do it.
> Thank you! :-)

Glad to know :)

>
> Acked-by: Gilad Ben-Yossef <gilad@...yossef.com>
>
>
>> Changes in v5:
>>  - Correct the format of the subject.
>>  drivers/staging/ccree/ssi_cipher.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
>> index 8d31a93..1ff3c8a 100644
>> --- a/drivers/staging/ccree/ssi_cipher.c
>> +++ b/drivers/staging/ccree/ssi_cipher.c
>> @@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev,
>>                                   void __iomem *cc_base)
>>  {
>>         int completion_error = 0;
>> -       u32 inflight_counter;
>>         struct ablkcipher_request *req = (struct ablkcipher_request *)areq;
>>
>>         ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
>>
>> -       /*Set the inflight couter value to local variable*/
>> -       inflight_counter =  ctx_p->drvdata->inflight_counter;
>>         /*Decrease the inflight counter*/
>>         if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
>>                 ctx_p->drvdata->inflight_counter--;
>> --
>> 2.7.4
>>
>
>
>
> --
> Gilad Ben-Yossef
> Chief Coffee Drinker
>
> "If you take a class in large-scale robotics, can you end up in a
> situation where the homework eats your dog?"
>  -- Jean-Baptiste Queru

Regards,
Srishti