linux-kernel - Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1504780406.7546.19.camel@perches.com>
Date:   Thu, 07 Sep 2017 03:33:26 -0700
From:   Joe Perches <joe@...ches.com>
To:     gaurav jindal <gauravjindal1104@...il.com>, rjw@...ysocki.net,
        daniel.lezcano@...aro.org
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        toddpoynor@...gle.com
Subject: Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings

On Thu, 2017-09-07 at 15:53 +0530, gaurav jindal wrote:
> This patch fixes the below checkpatch errors and warnings in
> drivers/cpuidle/cpuidle.c

If you are going to propose a checkpatch only patch,
please run your proposed patch through checkpatch.

> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
[]
> 
> @@ -399,9 +400,12 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
>  	if (ret)
>  		return ret;
>  
> -	if (cpuidle_curr_governor->enable &&
> -	    (ret = cpuidle_curr_governor->enable(drv, dev)))
> -		goto fail_sysfs;
> +	if (cpuidle_curr_governor->enable) {
> +
> +		ret = cpuidle_curr_governor->enable(drv, dev);
> +		if (ret)
> +			goto fail_sysfs;
> +	}

checkpatch should complain here about unnecessary
blank line after open brace