linux-kernel - Re: [PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <adb813cf-e4f3-a9c6-1f7a-8c6d1638c28c@samsung.com>
Date:   Thu, 07 Sep 2017 13:27:45 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Hoegeun Kwon <hoegeun.kwon@...sung.com>, inki.dae@...sung.com,
        airlied@...ux.ie, kgene@...nel.org, krzk@...nel.org,
        robh+dt@...nel.org, mark.rutland@....com, catalin.marinas@....com,
        will.deacon@....com
Cc:     dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible.

Hi Hoegeun,

On 2017-09-07 11:39, Hoegeun Kwon wrote:
> Exynos 5250 and 5420 have different hardware rotation limits. However,
> currently it uses only one compatible - "exynos5-gsc". Since we have
> to distinguish between these two, we add different compatible.
>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@...sung.com>

The new values (5250/5420 specific) should replace old exynos5-gsc, 
there is no
point providing both in dts.

> ---
>   arch/arm/boot/dts/exynos5250.dtsi | 8 ++++----
>   arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
>   2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 8dbeb87..f795c76 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -637,7 +637,7 @@
>   		};
>   
>   		gsc_0:  gsc@...00000 {
> -			compatible = "samsung,exynos5-gsc";
> +			compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
>   			reg = <0x13e00000 0x1000>;
>   			interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
>   			power-domains = <&pd_gsc>;
> @@ -647,7 +647,7 @@
>   		};
>   
>   		gsc_1:  gsc@...10000 {
> -			compatible = "samsung,exynos5-gsc";
> +			compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
>   			reg = <0x13e10000 0x1000>;
>   			interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
>   			power-domains = <&pd_gsc>;
> @@ -657,7 +657,7 @@
>   		};
>   
>   		gsc_2:  gsc@...20000 {
> -			compatible = "samsung,exynos5-gsc";
> +			compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
>   			reg = <0x13e20000 0x1000>;
>   			interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
>   			power-domains = <&pd_gsc>;
> @@ -667,7 +667,7 @@
>   		};
>   
>   		gsc_3:  gsc@...30000 {
> -			compatible = "samsung,exynos5-gsc";
> +			compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
>   			reg = <0x13e30000 0x1000>;
>   			interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
>   			power-domains = <&pd_gsc>;
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 02d2f89..86afe77 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -658,7 +658,7 @@
>   		};
>   
>   		gsc_0: video-scaler@...00000 {
> -			compatible = "samsung,exynos5-gsc";
> +			compatible = "samsung,exynos5-gsc", "samsung,exynos5420-gsc";
>   			reg = <0x13e00000 0x1000>;
>   			interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
>   			clocks = <&clock CLK_GSCL0>;
> @@ -668,7 +668,7 @@
>   		};
>   
>   		gsc_1: video-scaler@...10000 {
> -			compatible = "samsung,exynos5-gsc";
> +			compatible = "samsung,exynos5-gsc", "samsung,exynos5420-gsc";
>   			reg = <0x13e10000 0x1000>;
>   			interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
>   			clocks = <&clock CLK_GSCL1>;

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland