linux-kernel - Re: [2/2] genirq: Warn when IRQ_NOAUTOEN is used with shared interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1682867.tATABVWsV9@np-p-burton>
Date:   Wed, 6 Sep 2017 18:18:51 -0700
From:   Paul Burton <paul.burton@...tec.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     LKML <linux-kernel@...r.kernel.org>,
        jeffy <jeffy.chen@...k-chips.com>,
        Brian Norris <briannorris@...omium.org>,
        Marc Zyngier <marc.zyngier@....com>, <dianders@...omium.org>,
        <tfiga@...omium.org>, <james.hogan@...tec.com>
Subject: Re: [2/2] genirq: Warn when IRQ_NOAUTOEN is used with shared interrupts

Hi Thomas,

On Wednesday, 6 September 2017 07:14:50 PDT Thomas Gleixner wrote:
> On Wed, 6 Sep 2017, Paul Burton wrote:
> > On Wednesday, 6 September 2017 01:16:48 PDT Thomas Gleixner wrote:
> > > What's the problem with IRQ_NOAUTOEN and do
> > > 
> > >        setup_percpu_irq();
> > >        enable_percpu_irq();
> > > 
> > > on the boot CPU and then later call it when the secondary CPUs come up
> > > in
> > > cpu bringup code or a hotplug state callback?
> > 
> > There's no problem with that at all, apart from that it triggers your
> > warning when the boot CPU calls setup_percpu_irq().
> 
> Ok, I misread the whole thing somehow. What you are saying is that you need
> per cpu interrupts which can be shared ....
> 
> Hrmpf, ok. I'll have a look from that side then

So actually it turns out that getting this to work involves more than just 
avoiding your warning. I have some code which is mostly working; I'll clean up 
& send it as an RFC hopefully tomorrow.

Thanks,
    Paul
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)