linux-kernel - Re: [PATCH] Staging: ccree: Prefer using BIT macro.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Sep 2017 15:53:50 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Srishti Sharma <srishtishar@...il.com>
Cc:     gilad@...yossef.com, devel@...verdev.osuosl.org,
        driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com,
        linux-crypto@...r.kernel.org
Subject: Re: [PATCH] Staging: ccree: Prefer using BIT macro.

On Thu, Sep 07, 2017 at 07:17:09PM +0530, Srishti Sharma wrote:
> Use BIT(x) instead of (1<<x), reported by checkpatch.pl.
> 
> Signed-off-by: Srishti Sharma <srishtishar@...il.com>
> ---
>  drivers/staging/ccree/ssi_cipher.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h
> index 296b375..6fbcf9d 100644
> --- a/drivers/staging/ccree/ssi_cipher.h
> +++ b/drivers/staging/ccree/ssi_cipher.h
> @@ -27,11 +27,11 @@
>  #include "ssi_buffer_mgr.h"
> 
>  /* Crypto cipher flags */
> -#define CC_CRYPTO_CIPHER_KEY_KFDE0    (1 << 0)
> -#define CC_CRYPTO_CIPHER_KEY_KFDE1    (1 << 1)
> -#define CC_CRYPTO_CIPHER_KEY_KFDE2    (1 << 2)
> -#define CC_CRYPTO_CIPHER_KEY_KFDE3    (1 << 3)
> -#define CC_CRYPTO_CIPHER_DU_SIZE_512B (1 << 4)
> +#define CC_CRYPTO_CIPHER_KEY_KFDE0    BIT(0)
> +#define CC_CRYPTO_CIPHER_KEY_KFDE1    BIT(1)
> +#define CC_CRYPTO_CIPHER_KEY_KFDE2    BIT(2)
> +#define CC_CRYPTO_CIPHER_KEY_KFDE3    BIT(3)
> +#define CC_CRYPTO_CIPHER_DU_SIZE_512B BIT(4)

Care to use a <TAB> here as well?  I know the original didn't, but the
cleaned up code should.

thanks,

greg k-h