linux-kernel - Re: [PATCH] perf sched timehist: Add pid and tid options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5769138-07d9-4ac2-b6a4-8ec4f05d582f@gmail.com>
Date:   Thu, 7 Sep 2017 09:07:24 -0600
From:   David Ahern <dsahern@...il.com>
To:     namhyung@...nel.org, acme@...hat.com
Cc:     linux-kernel@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH] perf sched timehist: Add pid and tid options

Hi Arnaldo:

are you ok with this change?

On 9/1/17 11:49 AM, David Ahern wrote:
> Add options to only show event for specific pid(s) and tid(s).
> 
> Signed-off-by: David Ahern <dsahern@...il.com>
> ---
>  tools/perf/Documentation/perf-sched.txt | 8 ++++++++
>  tools/perf/builtin-sched.c              | 4 ++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/tools/perf/Documentation/perf-sched.txt b/tools/perf/Documentation/perf-sched.txt
> index a092a2499e8f..55b67338548e 100644
> --- a/tools/perf/Documentation/perf-sched.txt
> +++ b/tools/perf/Documentation/perf-sched.txt
> @@ -106,6 +106,14 @@ OPTIONS for 'perf sched timehist'
>  --max-stack::
>  	Maximum number of functions to display in backtrace, default 5.
>  
> +-p=::
> +--pid=::
> +	Only show events for given process ID (comma separated list).
> +
> +-t=::
> +--tid=::
> +	Only show events for given thread ID (comma separated list).
> +
>  -s::
>  --summary::
>      Show only a summary of scheduling by thread with min, max, and average
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 322b4def8411..b7e8812ee80c 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -3363,6 +3363,10 @@ int cmd_sched(int argc, const char **argv)
>  	OPT_STRING(0, "time", &sched.time_str, "str",
>  		   "Time span for analysis (start,stop)"),
>  	OPT_BOOLEAN(0, "state", &sched.show_state, "Show task state when sched-out"),
> +	OPT_STRING('p', "pid", &symbol_conf.pid_list_str, "pid[,pid...]",
> +		   "analyze events only for given process id(s)"),
> +	OPT_STRING('t', "tid", &symbol_conf.tid_list_str, "tid[,tid...]",
> +		   "analyze events only for given thread id(s)"),
>  	OPT_PARENT(sched_options)
>  	};
>  
>