linux-kernel - Re: linux-next: build warning after merge of the tpmdd tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170907162101.rxacve5xsnvan3qs@linux.intel.com>
Date:   Thu, 7 Sep 2017 19:21:01 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Colin Ian King <colin.king@...onical.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the tpmdd tree

Colin, Stephen,

Thank you. I'll apply Colin's fix.

/Jarkko

On Thu, Sep 07, 2017 at 09:43:37AM +0100, Colin Ian King wrote:
> Thanks for reporting that Stephen, I've sent a fix to address this issue.
> 
> Colin
> 
> On 07/09/17 03:31, Stephen Rothwell wrote:
> > Hi Jarkko,
> > 
> > After merging the tpmdd tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > drivers/char/tpm/tpm_tis_core.c: In function 'probe_itpm':
> > drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> >   rc = tpm_tis_send_data(chip, cmd_getticks, len);
> >                                ^
> > drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
> >  static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
> >             ^
> > drivers/char/tpm/tpm_tis_core.c:477:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> >   rc = tpm_tis_send_data(chip, cmd_getticks, len);
> >                                ^
> > drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
> >  static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
> >             ^
> > 
> > Introduced by commit
> > 
> >   5e35bd8e06b9 ("tpm_tis: make array cmd_getticks static const to shink object code size")
> > 
>