linux-kernel - RE: [PATCH 1/1] ACPI: NULL pointer checking

Open Source and information security mailing list archives

Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37E60C211@ORSMSX110.amr.corp.intel.com>
Date:   Thu, 7 Sep 2017 19:26:56 +0000
From:   "Moore, Robert" <robert.moore@...el.com>
To:     "Moore, Robert" <robert.moore@...el.com>,
        Zhenhua <lizhenhuajiyang@....com>,
        "devel@...ica.org" <devel@...ica.org>,
        "Zheng, Lv" <lv.zheng@...el.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Schmauss, Erik" <erik.schmauss@...el.com>,
        "Box, David E" <david.e.box@...el.com>
Subject: RE: [PATCH 1/1] ACPI: NULL pointer checking

> -----Original Message-----
> From: Devel [mailto:devel-bounces@...ica.org] On Behalf Of Moore, Robert
> Sent: Wednesday, September 6, 2017 9:43 AM
> To: Zhenhua <lizhenhuajiyang@....com>; devel@...ica.org; Zheng, Lv
> <lv.zheng@...el.com>; Wysocki, Rafael J <rafael.j.wysocki@...el.com>;
> lenb@...nel.org; linux-acpi@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [Devel] [PATCH 1/1] ACPI: NULL pointer checking
> 
> 
> 
> > -----Original Message-----
> > From: Zhenhua [mailto:lizhenhuajiyang@....com]
> > Sent: Wednesday, September 6, 2017 6:35 AM
> > To: devel@...ica.org; Moore, Robert <robert.moore@...el.com>; Zheng,
> > Lv <lv.zheng@...el.com>; Wysocki, Rafael J
> > <rafael.j.wysocki@...el.com>; lenb@...nel.org;
> > linux-acpi@...r.kernel.org; linux- kernel@...r.kernel.org
> > Cc: Zhenhua <lizhenhuajiyang@....com>
> > Subject: [PATCH 1/1] ACPI: NULL pointer checking
> >
> > These two pointers should be checked, for some broken devices they may
> > cause system crash.
> >
> > Signed-off-by: Zhenhua <lizhenhuajiyang@....com>
> > ---
> >  drivers/acpi/acpica/nsaccess.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/acpi/acpica/nsaccess.c
> > b/drivers/acpi/acpica/nsaccess.c index f2733f51ca8d..151abb0ef4d5
> > 100644
> > --- a/drivers/acpi/acpica/nsaccess.c
> > +++ b/drivers/acpi/acpica/nsaccess.c
> > @@ -338,7 +338,7 @@ acpi_ns_lookup(union acpi_generic_state
> *scope_info,
> >  			return_ACPI_STATUS(AE_AML_INTERNAL);
> >  		}
> >
> > -		if (!(flags & ACPI_NS_PREFIX_IS_SCOPE)) {
> > +		if ((!prefix_node) && (!(flags & ACPI_NS_PREFIX_IS_SCOPE))) {
> [Moore, Robert]
> 
> Is there an actual case where the original code failed?
> 
> 
[Moore, Robert] 

Prefix_node is guaranteed to be valid at this point in the code.

> 
> >  			/*
> >  			 * This node might not be a actual "scope" node (such as
> a
> >  			 * Device/Method, etc.)  It could be a Package or other
> object @@
> > -369,7 +369,7 @@ acpi_ns_lookup(union acpi_generic_state *scope_info,
> >  		ACPI_DEBUG_PRINT((ACPI_DB_NAMES,
> >  				  "Null Pathname (Zero segments), Flags=%X\n",
> >  				  flags));
> > -	} else {
> > +	} else if (path) {
[Moore, Robert] 

Likewise, "path" is guaranteed to be valid at this point.

> >  		/*
> >  		 * Name pointer is valid (and must be in internal name
> > format)
> >  		 *
> > --
> > 2.14.1
> >
> 
> _______________________________________________
> Devel mailing list
> Devel@...ica.org
> https://lists.acpica.org/mailman/listinfo/devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives