lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 07 Sep 2017 13:27:21 -0700 From: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com> To: Borislav Petkov <bp@...e.de> Cc: Ingo Molnar <mingo@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, "H. Peter Anvin" <hpa@...or.com>, Andy Lutomirski <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Andrew Morton <akpm@...ux-foundation.org>, Brian Gerst <brgerst@...il.com>, Chris Metcalf <cmetcalf@...lanox.com>, Dave Hansen <dave.hansen@...ux.intel.com>, Paolo Bonzini <pbonzini@...hat.com>, Masami Hiramatsu <mhiramat@...nel.org>, Huang Rui <ray.huang@....com>, Jiri Slaby <jslaby@...e.cz>, Jonathan Corbet <corbet@....net>, "Michael S. Tsirkin" <mst@...hat.com>, Paul Gortmaker <paul.gortmaker@...driver.com>, Vlastimil Babka <vbabka@...e.cz>, Chen Yucong <slaoub@...il.com>, "Ravi V. Shankar" <ravi.v.shankar@...el.com>, Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org, x86@...nel.org, Adam Buchbinder <adam.buchbinder@...il.com>, Colin Ian King <colin.king@...onical.com>, Lorenzo Stoakes <lstoakes@...il.com>, Qiaowei Ren <qiaowei.ren@...el.com>, Arnaldo Carvalho de Melo <acme@...hat.com>, Adrian Hunter <adrian.hunter@...el.com>, Kees Cook <keescook@...omium.org>, Thomas Garnier <thgarnie@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com> Subject: Re: [PATCH v8 09/28] x86/insn-eval: Do not BUG on invalid register type On Thu, 2017-09-07 at 19:54 +0200, Borislav Petkov wrote: > > Also, I meant to add it to pr_fmt. Feel free to merge this hunk ontop > of > yours: > > --- > diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c > index 3919458fecbf..d46034ddfbb7 100644 > --- a/arch/x86/lib/insn-eval.c > +++ b/arch/x86/lib/insn-eval.c > @@ -10,6 +10,9 @@ > #include <asm/insn.h> > #include <asm/insn-eval.h> > > +#undef pr_fmt > +#define pr_fmt(fmt) "insn: " fmt > + > enum reg_type { > REG_TYPE_RM = 0, > REG_TYPE_INDEX, > @@ -86,7 +89,7 @@ static int get_reg_offset(struct insn *insn, struct > pt_regs *regs, > break; > > default: > - pr_err_ratelimited("insn: x86: invalid register > type"); > + pr_err_ratelimited("invalid register type: %d\n", > type); > return -EINVAL; > } > Oh, I didn't understand your comment initially. Sure, I will add merge this on top of my patch. Thanks and BR, Ricardo
Powered by blists - more mailing lists