linux-kernel - Re: [Outreachy kernel] [PATCH] Staging:pi433:pi433

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Sep 2017 23:45:56 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     harsha <harshasharmaiitr@...il.com>
cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging:pi433:pi433_if.c:Fixes minor
 typo errors



On Fri, 8 Sep 2017, harsha wrote:

> Fixes checkpatch warning -- "occured" and "succesfully" are misspelled

Thanks for the patch.  The change looks ok, but the subject line is not.
Use git log --oneline on the affected file to see what others have done.
In general, you cannot guess what the subject line should be.  But in
almost all cases, there is a space after each : and a filename, if it
needs to be included, does not have an extension.

julia

>
> Signed-off-by: Harsha Sharma <harshasharmaiitr@...il.com>
> ---
>  drivers/staging/pi433/pi433_if.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 6b9b7df..6a10478 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -473,7 +473,7 @@ struct pi433_instance {
>  	}
>
>
> -	/* rx done, wait was interrupted or error occured */
> +	/* rx done, wait was interrupted or error occurred */
>  abort:
>  	dev->interrupt_rx_allowed = true;
>  	SET_CHECKED(rf69_set_mode(dev->spi, standby));
> @@ -1033,7 +1033,7 @@ static int setup_GPIOs(struct pi433_device *device)
>  		if (retval)
>  			return retval;
>
> -		dev_dbg(&device->spi->dev, "%s succesfully configured", name);
> +		dev_dbg(&device->spi->dev, "%s successfully configured", name);
>  	}
>
>  	return 0;
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504816316-9331-1-git-send-email-harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>