linux-kernel - Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jUcC7e3R_fRrPuKCaCmi3ZQwKWBJTmC7zN09QaErQXrw@mail.gmail.com>
Date:   Fri, 8 Sep 2017 01:18:49 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     gaurav jindal <gauravjindal1104@...il.com>
Cc:     Joe Perches <joe@...ches.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Todd Poynor <toddpoynor@...gle.com>
Subject: Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings

On Thu, Sep 7, 2017 at 2:40 PM, gaurav jindal
<gauravjindal1104@...il.com> wrote:
> this patch fixes the below checkpatch errors and warnings in
> drivers/cpuidle/cpuidle.c
>
> WARNING: line over 80 characters
> #311: FILE: drivers/cpuidle/cpuidle.c:311:
> +               /* Make sure all changes finished before we switch to new idle */
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #343: FILE: drivers/cpuidle/cpuidle.c:343:
> +EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #354: FILE: drivers/cpuidle/cpuidle.c:354:
> +EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
>
> ERROR: do not use assignment in if condition
> #402: FILE: drivers/cpuidle/cpuidle.c:402:
> +       if (cpuidle_curr_governor->enable &&
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #419: FILE: drivers/cpuidle/cpuidle.c:419:
> +EXPORT_SYMBOL_GPL(cpuidle_enable_device);
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #447: FILE: drivers/cpuidle/cpuidle.c:447:
> +EXPORT_SYMBOL_GPL(cpuidle_disable_device);
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #537: FILE: drivers/cpuidle/cpuidle.c:537:
> +EXPORT_SYMBOL_GPL(cpuidle_register_device);
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #561: FILE: drivers/cpuidle/cpuidle.c:561:
> +EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
>
> Signed-off-by:gaurav jindal<gauravjindal1104@...il.com>
>
> ---
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index 60bb64f..a42148e 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -308,7 +308,10 @@ void cpuidle_reflect(struct cpuidle_device *dev, int index)
>  void cpuidle_install_idle_handler(void)
>  {
>         if (enabled_devices) {
> -               /* Make sure all changes finished before we switch to new idle */
> +               /*
> +                * Make sure all changes finished before we switch to
> +                * new idle
> +                */
>                 smp_wmb();
>                 initialized = 1;
>         }

Don't do this.

The rest is fine by me.