linux-kernel - Re: [PATCH] security/keys: Adding newline after declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1504763697.7546.9.camel@perches.com>
Date:   Wed, 06 Sep 2017 22:54:57 -0700
From:   Joe Perches <joe@...ches.com>
To:     Pushkar Jambhlekar <pushkar.iit@...il.com>,
        David Howells <dhowells@...hat.com>,
        James Morris <james.l.morris@...cle.com>,
        "Serge E. Hallyn" <serge@...lyn.com>
Cc:     keyrings@...r.kernel.org, linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] security/keys: Adding newline after declaration

On Thu, 2017-09-07 at 11:11 +0530, Pushkar Jambhlekar wrote:
> Fixing checkpatch warning to add newline after declaration
[]
> diff --git a/security/keys/big_key.c b/security/keys/big_key.c
[]
> @@ -93,6 +93,7 @@ static int big_key_crypt(enum big_key_op op, u8 *data, size_t datalen, u8 *key)
>  {
>  	int ret = -EINVAL;
>  	struct scatterlist sgio;
> +
>  	SKCIPHER_REQUEST_ON_STACK(req, big_key_skcipher);

checkpatch doesn't know that SKCIPHER_REQUEST_ON_STACK
is actually 2 declarations.