linux-kernel - Re: [PATCH 1/4] sched/sched.h: remove duplicate prototype of __dl_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f4582ad-d3ee-7094-ba31-bdaf0c1ee9e4@redhat.com>
Date:   Fri, 8 Sep 2017 10:33:46 +0200
From:   Daniel Bristot de Oliveira <bristot@...hat.com>
To:     luca abeni <luca.abeni@...tannapisa.it>,
        linux-kernel@...r.kernel.org
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Juri Lelli <juri.lelli@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>
Subject: Re: [PATCH 1/4] sched/sched.h: remove duplicate prototype of
 __dl_clear_params()

Hi,

I wonder if a commit log, even an one line comment, explaining that this
function was already declared in the file could help to understand this
patch...

But, the patch is so trivial... that... not sure it is worth... anyway...

On 09/07/2017 12:09 PM, luca abeni wrote:
> Signed-off-by: luca abeni <luca.abeni@...tannapisa.it>

Reviewed-by: Daniel Bristot de Oliveira <bristot@...hat.com>

-- Daniel

> ---
>  kernel/sched/sched.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 1043c8b..0b93e4b 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -255,7 +255,6 @@ extern int sched_dl_overflow(struct task_struct *p, int policy,
>  extern void __setparam_dl(struct task_struct *p, const struct sched_attr *attr);
>  extern void __getparam_dl(struct task_struct *p, struct sched_attr *attr);
>  extern bool __checkparam_dl(const struct sched_attr *attr);
> -extern void __dl_clear_params(struct task_struct *p);
>  extern bool dl_param_changed(struct task_struct *p, const struct sched_attr *attr);
>  extern int dl_task_can_attach(struct task_struct *p,
>  			      const struct cpumask *cs_cpus_allowed);
>