linux-kernel - Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Sep 2017 12:50:39 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     harsha <harshasharmaiitr@...il.com>, devel@...verdev.osuosl.org,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo
 errors

On Fri, Sep 08, 2017 at 11:45:20AM +0200, Julia Lawall wrote:
> 
> 
> On Fri, 8 Sep 2017, harsha wrote:
> 
> > From: Harsha Sharma <harshasharmaiitr@...il.com>
> >
> > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled
> >
> > Signed-off-by: Harsha Sharma <harshasharmaiitr@...il.com>
> > ---
> > Changes in v4:
> >  -Correct the format of the subject.
> >  -Signed-off properly.
> 
> It's not signed off properly.  Like Greg just said (maybe the mails
> crossed), the sign off needs to be the same as the From line.  This
> probably relates to your git configuration or your mailer.  Send the patch
> to yourself before sending it out on the mailing list to be sure that
> everything is ok.
> 

This is actually OK-ish...  It's better when we don't have the extra
From: and there is no need for that with gmail, but we sometimes allow
it for companies which have broken mailservers.

regards,
dan carpenter