linux-kernel - Re: [PATCH v3 5/6] [media] exynos-gsc: Remove unnecessary compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPfyrH66X3iPLaXK_OJgadU6HByyjTwfp_6xYasq8cS-Lw@mail.gmail.com>
Date:   Fri, 8 Sep 2017 13:24:05 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Hoegeun Kwon <hoegeun.kwon@...sung.com>
Cc:     Inki Dae <inki.dae@...sung.com>, airlied@...ux.ie,
        kgene@...nel.org, robh+dt@...nel.org, mark.rutland@....com,
        catalin.marinas@....com, will.deacon@....com, mchehab@...nel.org,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        dri-devel@...ts.freedesktop.org, linux-media@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, a.hajda@...sung.com
Subject: Re: [PATCH v3 5/6] [media] exynos-gsc: Remove unnecessary compatible

On Fri, Sep 8, 2017 at 8:02 AM, Hoegeun Kwon <hoegeun.kwon@...sung.com> wrote:
> Currently, the compatible('samsung,exynos5-gsc') is not used.
> Remove unnecessary compatible.
>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@...sung.com>
> ---
>  Documentation/devicetree/bindings/media/exynos5-gsc.txt | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/exynos5-gsc.txt b/Documentation/devicetree/bindings/media/exynos5-gsc.txt
> index daa56d5..1ea05f1 100644
> --- a/Documentation/devicetree/bindings/media/exynos5-gsc.txt
> +++ b/Documentation/devicetree/bindings/media/exynos5-gsc.txt
> @@ -3,9 +3,9 @@
>  G-Scaler is used for scaling and color space conversion on EXYNOS5 SoCs.
>
>  Required properties:
> -- compatible: should be "samsung,exynos5-gsc" (for Exynos 5250, 5420 and
> -             5422 SoCs) or "samsung,exynos5433-gsc" (Exynos 5433)
> -             or "samsung,exynos5250-gsc" or "samsung,exynos5420-gsc"
> +- compatible: should be "samsung,exynos5250-gsc", "samsung,exynos5420-gsc"
> +             or "samsung,exynos5433-gsc" (for Exynos 5250, 5420, 5422,
> +             and 5433 SoCs)

You should not remove the compatible (neither here nor in the driver)
but mark it as deprecated. Removal should happen slightly later.

Best regards,
Krzysztof

>  - reg: should contain G-Scaler physical address location and length.
>  - interrupts: should contain G-Scaler interrupt number
>
> @@ -16,7 +16,7 @@ Optional properties:
>  Example:
>
>  gsc_0:  gsc@...3e00000 {
> -       compatible = "samsung,exynos5-gsc";
> +       compatible = "samsung,exynos5250-gsc;
>         reg = <0x13e00000 0x1000>;
>         interrupts = <0 85 0>;
>  };