linux-kernel - Re: [PATCH V2] thermal/drivers/step_wise: Fix temperature regulation misbehavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <535fbdfe-6e6b-84b1-90b8-592aed46c6b2@linaro.org>
Date:   Fri, 8 Sep 2017 15:59:07 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Keerthy <j-keerthy@...com>, rui.zhang@...el.com,
        edubezval@...il.com
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        john.stultz@...aro.org, leo.yan@...aro.org
Subject: Re: [PATCH V2] thermal/drivers/step_wise: Fix temperature regulation
 misbehavior

On 08/09/2017 14:25, Keerthy wrote:
> 
[ ... ]

> This definitely is an issue i have seen on dra7 and if step_wise by
> design can accommodate this change, It will fix the issue!

Ah, ok. I understood you thought we should not do the change and use the
DT crit trip instead.

> Then you should be updating the documentation as well.
> 
> /*
>  * If the temperature is higher than a trip point,
>  *    a. if the trend is THERMAL_TREND_RAISING, use higher cooling
>  *       state for this trip point
>  *    b. if the trend is THERMAL_TREND_DROPPING, use lower cooling
>  *       state for this trip point
> 
> Now with your patch applied the point b. will change to:
> 
> b. if the trend is THERMAL_TREND_DROPPING, Maintain the same cooling
> level till the temperature drops below trip point.

Ok, I will change accordingly.

Thanks.

  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog