linux-kernel - Re: [PATCH v5 1/3] perf config: Check not only section->from_system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170908143148.GH11725@kernel.org>
Date:   Fri, 8 Sep 2017 11:31:48 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Taeung Song <treeze.taeung@...il.com>
Cc:     linux-kernel@...r.kernel.org, taeung@...slab.kr,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v5 1/3] perf config: Check not only
 section->from_system_config but also item's

Em Thu, Sep 07, 2017 at 12:18:45PM +0900, Taeung Song escreveu:
> Currently only section->from_system_config is being checked multiple times.
> items->from_system_config should be also checked, so fix it.

Reworded the cset log as:

    perf config: Check not only section->from_system_config but also item's
    
    Currently section->from_system_config is being checked multiple times.
    item->from_system_config should be checked instead, when iterating thru
    the items in a section. Fix it.


applied.

- Arnaldo
 
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Signed-off-by: Taeung Song <treeze.taeung@...il.com>
> ---
>  tools/perf/builtin-config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
> index 3ddcc6e..a1d82e3 100644
> --- a/tools/perf/builtin-config.c
> +++ b/tools/perf/builtin-config.c
> @@ -59,7 +59,7 @@ static int set_config(struct perf_config_set *set, const char *file_name,
>  		fprintf(fp, "[%s]\n", section->name);
>  
>  		perf_config_items__for_each_entry(&section->items, item) {
> -			if (!use_system_config && section->from_system_config)
> +			if (!use_system_config && item->from_system_config)
>  				continue;
>  			if (item->value)
>  				fprintf(fp, "\t%s = %s\n",
> -- 
> 2.7.4