linux-kernel - Re: [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB3L5owMjYyFcLQP7p_+R2DzZz3KpUhCxaVrB0qJeJh08UzM1w@mail.gmail.com>
Date:   Fri, 8 Sep 2017 20:29:33 +0530
From:   Srishti Sharma <srishtishar@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        outreachy-kernel@...glegroups.com,
        laurent.pinchart@...asonboard.com, mchehab@...nel.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().

On Fri, Sep 8, 2017 at 8:08 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Fri, Sep 08, 2017 at 07:38:18PM +0530, Srishti Sharma wrote:
>> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
>>
>> Signed-off-by: Srishti Sharma <srishtishar@...il.com>
>> ---
>>  drivers/staging/media/omap4iss/iss.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
>> index c26c99fd..b1036ba 100644
>> --- a/drivers/staging/media/omap4iss/iss.c
>> +++ b/drivers/staging/media/omap4iss/iss.c
>> @@ -893,7 +893,7 @@ void omap4iss_put(struct iss_device *iss)
>>               return;
>>
>>       mutex_lock(&iss->iss_mutex);
>> -     BUG_ON(iss->ref_count == 0);
>> +     WARN_ON(iss->ref_count == 0);
>
> ref_counting bugs often have a security aspect.  BUG_ON() is probably
> safer here.  Better to crash than to lose all your bitcoin.

Okay, Thanks for this.

Regards,
Srishti

>
> regards,
> dan carpenter
>