linux-kernel - Re: [Outreachy kernel] [PATCH v2] staging: typec: tcpm: Comparison to NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1709081941430.22293@hadrien>
Date:   Fri, 8 Sep 2017 19:42:55 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Harsha Sharma <harshasharmaiitr@...il.com>
cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] staging: typec: tcpm: Comparison
 to NULL pointer

Maybe "Rewrite comparison to NULL pointer" in the subject to include what
was done, not just code was touched.

On Fri, 8 Sep 2017, Harsha Sharma wrote:

> Makes code more concise and readable

Makes -> Make.  Commit logs should be written in the imperative, like you
are telling someone what to do.

julia

> Signed-off-by: Harsha Sharma <harshasharmaiitr@...il.com>
> ---
> Change in v2:
>  -Change in subject
>  -Change in log message
>  drivers/staging/typec/tcpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
> index 630fe75..9f4a5a5 100644
> --- a/drivers/staging/typec/tcpm.c
> +++ b/drivers/staging/typec/tcpm.c
> @@ -982,7 +982,7 @@ static void svdm_consume_modes(struct tcpm_port *port, const __le32 *payload,
>  	}
>  	port->partner_altmode[pmdata->altmodes] =
>  		typec_partner_register_altmode(port->partner, paltmode);
> -	if (port->partner_altmode[pmdata->altmodes] == NULL) {
> +	if (!port->partner_altmode[pmdata->altmodes]) {
>  		tcpm_log(port,
>  			 "Failed to register alternate modes for SVID 0x%04x",
>  			 paltmode->svid);
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504892391-5607-1-git-send-email-harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>