linux-kernel - Re: [netfilter-core] [PATCH] netfilter: nat: constify rhashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170908174718.GA1727@salvia>
Date:   Fri, 8 Sep 2017 19:47:18 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        coreteam@...filter.org, netfilter-devel@...r.kernel.org,
        kadlec@...ckhole.kfki.hu, davem@...emloft.net
Subject: Re: [netfilter-core] [PATCH] netfilter: nat: constify
 rhashtable_params

On Fri, Sep 08, 2017 at 01:46:30PM +0200, Pablo Neira Ayuso wrote:
> On Wed, Aug 30, 2017 at 05:18:04PM +0530, Arvind Yadav wrote:
> > rhashtable_params are not supposed to change at runtime. All
> > Functions rhashtable_* working with const rhashtable_params
> > provided by <linux/rhashtable.h>. So mark the non-const structs
> > as const.
> 
> Applied to nf, thanks.

Actually, I tossed this. NAT rhashtable has been reverted, so no need
for this constification anymore.