linux-kernel - Re: [PATCH v3 08/13] xen/pvcalls: implement accept command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Sep 2017 14:58:11 -0700 (PDT)
From:   Stefano Stabellini <sstabellini@...nel.org>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>
cc:     Stefano Stabellini <sstabellini@...nel.org>,
        xen-devel@...ts.xen.org, linux-kernel@...r.kernel.org,
        jgross@...e.com, Stefano Stabellini <stefano@...reto.com>
Subject: Re: [PATCH v3 08/13] xen/pvcalls: implement accept command

On Mon, 14 Aug 2017, Boris Ostrovsky wrote:
> > > +
> > > +    ret = bedata->rsp[req_id].ret;
> > 
> > You can just return bedata->rsp[req_id].ret;
> 
> Or maybe not. The slot may get reused by the time you get to the end.

Right!

> > 
> > -boris
> > 
> > > +    /* read ret, then set this rsp slot to be reused */
> > > +    smp_mb();
> > > +    WRITE_ONCE(bedata->rsp[req_id].req_id, PVCALLS_INVALID_ID);
> > > +    WRITE_ONCE(map->passive.inflight_req_id, PVCALLS_INVALID_ID);
> > > +    return ret;
> > > +}
>