linux-kernel - Re: [PATCH v2] leds: pca955x: Don't invert requested value in pca955x_gpio_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACPK8XeoZknwJ8VqSgvbzgWVBgCxiB2GB6n--LXEUVDodND6DQ@mail.gmail.com>
Date:   Fri, 8 Sep 2017 15:23:11 +0930
From:   Joel Stanley <joel@....id.au>
To:     Cédric Le Goater <clg@...d.org>
Cc:     Andrew Jeffery <andrew@...id.au>, linux-leds@...r.kernel.org,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        rpurdie@...ys.net, jacek.anaszewski@...il.com, pavel@....cz,
        Brandon Wyman <bjwyman@...il.com>
Subject: Re: [PATCH v2] leds: pca955x: Don't invert requested value in pca955x_gpio_set_value()

On Sat, Sep 2, 2017 at 2:36 AM, Cédric Le Goater <clg@...d.org> wrote:
> On 09/01/2017 07:38 AM, Andrew Jeffery wrote:

>> Rework leds-pca955x so that we avoid the incorrect inversion and clarify
>> the semantics with respect to GPIO.
>>
>> Signed-off-by: Andrew Jeffery <andrew@...id.au>
>
> Reviewed-by: Cédric Le Goater <clg@...d.org>

I gave this a spin on our 'witherspoon' system and the LEDs responded
as expected.

Tested-by: Joel Stanley <joel@....id.au>

Cheers,

Joel