linux-kernel - Re: [PATCH 1/1] [staging]: android:ion: replace BUG with WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 9 Sep 2017 16:17:26 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Pintu Kumar <pintu_agarwal@...oo.com>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        riandrews@...roid.com, arve@...roid.com, sumit.semwal@...aro.org,
        labbott@...hat.com, pintu.k@...look.com, pintu.ping@...il.com
Subject: Re: [PATCH 1/1] [staging]: android:ion: replace BUG with WARN_ON

On Sat, Sep 09, 2017 at 06:59:42PM +0530, Pintu Kumar wrote:
> This patch is the fix for the below checkpatch issue:
> CHECK: Avoid crashing the kernel - try using WARN_ON &
> recovery code rather than BUG() or BUG_ON()
> +	BUG();
> 
> Ideally this condition should never occur. But even if occurs
> there is no point in crashing the whole kernel.
> Just a warning should be enough to find the issue.

Nope, see the archives for when this has been rejected in the past.

You can't just trivially replace BUG with WARN, otherwise it would have
been done already :)

sorry,

greg k-h